Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update patch to take into account a limitation of autosubst #42

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

kyoDralliam
Copy link
Contributor

I forgot to include an update of the patch file in the id pr (#41) that's needed because of what seems to be a limitation of autosubst (see there).

@MevenBertrand
Copy link
Member

MevenBertrand commented Aug 29, 2023

Since we do not use all this free variable stuff, would it be simply cleaner to stop using that option until the bug is fixed in AutoSubst? (Hopefully, the need for that ugly patch will disappear soon enough anyway)

@MevenBertrand
Copy link
Member

Also, unrelated, but I forgot to fix it before, and now is probably a good time to do so: should we rename the AutoSubst syntax file from PiUniv.sig to something more relevant?

@kyoDralliam
Copy link
Contributor Author

If we do not use any of the facilities provided by -allfv, indeed we could drop the option to regenerate the autosubt files. For now I would rather keep this PR (and maybe remove the allfv business in another PR) in order to keep this solution in the git history.
I don't have any strong opinion on the name of the signaure file.

@MevenBertrand MevenBertrand merged commit 9fc8722 into master Sep 1, 2023
2 checks passed
@MevenBertrand MevenBertrand deleted the update-patch branch September 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants