Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing full screen menu item #2210

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fixing full screen menu item #2210

merged 1 commit into from
Apr 11, 2022

Conversation

georgweiss
Copy link
Collaborator

Verified on Mac and Windows using menu item.

Could not verify using F11 on Windows, do not know why. Maybe a keyboard issue, tried two different keyboards, got two different results, none of them full screen transition.

@georgweiss georgweiss requested a review from kasemir April 11, 2022 16:37
@kasemir
Copy link
Collaborator

kasemir commented Apr 11, 2022

Looks good.
As for F11, I don't think we tie any key combination to the full screen action.
On the contrary, in

stage.setFullScreenExitKeyCombination(KeyCombination.NO_MATCH);
we try to prevent any key combination from exiting full screen mode, because the idea was to use this for "kiosk" displays where the user should not be able to exit via a keyboard. So F11 might be handled by the operating system beyond our control.

@georgweiss georgweiss merged commit 728552b into master Apr 11, 2022
@georgweiss georgweiss deleted the Issue_2208 branch April 11, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants