Rectangle: Use either legacy "line" or "border" #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. whichever has a larger "width". Honor the "border_color" instead of always using black resp. "Text" color. #2203
|
Thanks for fixing the color part |
|
No problem. I've never seen an issue locally because I guess we either tweaked the legacy display to function with both BOY and display builder, or just updated for the display builder. There will be irreconcilable cases where a border style of "none" was still shown in BOY, or both "border" and "line" were defined. I don't think we can/will automatically solve all of these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. whichever has a larger "width". Used to ignore "line" and always use the "border" settings.
If indeed using the "border", now honors the "border_color" instead of always using black resp. "Text" color.
See #2203 for screenshots