Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot config dialog optional in data browser #2185

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

georgweiss
Copy link
Collaborator

New preference setting:
org.csstudio.trends.databrowser3/config_dialog_supported

Defaults to false in the context of the data browser.

@georgweiss georgweiss requested a review from kasemir March 21, 2022 07:55
@georgweiss georgweiss merged commit dae8b4e into master Mar 21, 2022
@georgweiss georgweiss deleted the plot_settings branch March 21, 2022 12:50
@kasemir
Copy link
Collaborator

kasemir commented Mar 21, 2022

Defaults to false in the context of the data browser.

That's a change, supporting it by default would be "smoother", but I agree that we do want to disable it by default.

@georgweiss
Copy link
Collaborator Author

That's a change, supporting it by default would be "smoother", but I agree that we do want to disable it by default.

Ultimately sites will need to override, no matter what we choose as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants