Add Dockerfile and use docker in CI #2166
Conversation
-Add docker-tests profile. -Update CI to use docker image. -Update docs.
|
Thanks |
|
Yes. And I would have liked to build it every time I push it, but it requires a token from my account. It is built every time this fork is built. |
There was a problem hiding this comment.
Thank you for the MR, @lorenzo-gomez-windhover .
This looks like a good MR. I added a couple of comments on the Dockerfile.
misc/Dockerfile
Outdated
| @@ -0,0 +1,11 @@ | |||
| FROM ubuntu:18.04 | |||
There was a problem hiding this comment.
Is there any reason for using ubuntu:18.04? It is not the latest LTS version for Ubuntu.
Have you tried using the official images for OpenJDK or even Maven?
There was a problem hiding this comment.
There is no reason. I just forgot that Ubuntu 18 is not LTS anymore :).
|
@lorenzo-gomez-windhover do you want me to wait till you update the PR with anders suggestions |
|
I believe all of the concerns have been addressed. Sorry for delays in responses. Things have been quite busy lately... |
As discussed in #2156, some unit tests do not pass in a docker image since there are multiple issues related to IPV6. This PR addresses those issues.
During this process, I also learned that GitHub Actions has some issues related to Maven network timeouts. See actions/runner-images#1499. Specifically in our case GitHub Actions would hang forever(until eventually it times out) when we used the new
docker-testsprofile when running maven. The new flags inMAVEN_OPTSseems to fix it. I don't know if there is something in those flags that we shouldn't be doing, so please give me feedback if there is. I pretty much stole the config from here Ericsson/ecchronos#275.Hope these changes make sense.
Thanks
Lorenzo