Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create the welcome if a layout was passed #2162

Closed
wants to merge 2 commits into from

Conversation

mgotz
Copy link
Contributor

@mgotz mgotz commented Mar 7, 2022

Address #2159 by not creating a welcome tab, if the -layout was passed.

@kasemir
Copy link
Collaborator

kasemir commented Mar 14, 2022

As you say in the last commit, "order matters".
I'm a little worried about the way -layout /path/to/xxx.memento is only partially removed, and then there's this check

         if (!application_parameters.contains("-clean") &&
             !restoreState(memento) &&
             !application_parameters.remove("-layout"))

which will remove the remaining -layout from the application_parameters, but only if there's no -clean flag, because otherwise the shortcut-behavior of && will skip the application_parameters.remove(.

Please triple-check that all command line combinations still "work", and/or simplify by introducing some new "suppress_welcome" flag that's set when first handling the -layout, then remove the complete -layout at that time.

@kasemir
Copy link
Collaborator

kasemir commented Mar 18, 2022

Alternate PR uses an explicit show_welcome flag.

@kasemir
Copy link
Collaborator

kasemir commented Mar 21, 2022

Handled by #2184

@kasemir kasemir closed this Mar 21, 2022
@mgotz mgotz deleted the no-welcome-layout branch March 23, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants