Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to display info irrespective of right-click position #2144

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

georgweiss
Copy link
Collaborator

@georgweiss georgweiss commented Feb 18, 2022

Accessing display info from context menu item can be tricky if the OPI is very busy or if it uses a symbol widget as a background.

This PR adds a menu item for the display info regardless of where user clicks, see screen shot. In case user actually clicks in a position where no other widget is in the foreground, the additional context menu item is not added.

Screenshot 2022-02-18 at 14 37 58

@georgweiss georgweiss requested a review from kasemir February 18, 2022 13:37
@georgweiss
Copy link
Collaborator Author

@kasemir, @shroffk, I'd appreciate if you can add your input.

@kasemir
Copy link
Collaborator

kasemir commented Feb 21, 2022

Looks like this is really a 10 line change, but since it updates the formatting of the whole file, it's harder to read.

@georgweiss
Copy link
Collaborator Author

Yes, Cmd + Option + L in IntelliJ can be deceptive...
Do you need me to revert formatting in order to review?

@kasemir
Copy link
Collaborator

kasemir commented Feb 21, 2022

Well, yes, I would appreciate that.

@georgweiss
Copy link
Collaborator Author

@kasemir, updated as requested.

@kasemir
Copy link
Collaborator

kasemir commented Feb 21, 2022

Thanks! When I look at the "Files Changed" section on github, the formatting is still all changed, which doesn't line up with the "Reverting formatting" commit. I'm assuming that's a github rendering issue, so go ahead.

@georgweiss
Copy link
Collaborator Author

"Go ahead" as in....?

@kasemir
Copy link
Collaborator

kasemir commented Feb 21, 2022

.. merge?

@georgweiss
Copy link
Collaborator Author

Asking for the record.

@georgweiss georgweiss merged commit fd23f0e into master Feb 21, 2022
@georgweiss georgweiss deleted the CSSTUDIO-1628 branch February 21, 2022 19:46
@kasemir
Copy link
Collaborator

kasemir commented Feb 21, 2022

Well, looks like it didn't revert the formatting in the end. You win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants