Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phoebus.bat fails to find java when first executed #2140

Closed
kurup opened this issue Feb 17, 2022 · 3 comments
Closed

phoebus.bat fails to find java when first executed #2140

kurup opened this issue Feb 17, 2022 · 3 comments

Comments

@kurup
Copy link
Contributor

kurup commented Feb 17, 2022

The phoebus.bat script doesn't assign the JAVA_HOME variable with ENABLEDELAYEDEXPANSION set so the variable is not assigned properly when the script is first executed, which means the version of java in ../jdk is not found. Subsequent execution of the script works. This is fixed when set ENABLEDELAYEDEXPANSION is at the top of the script and %JAVA_HOME% is replaced with !JAVA_HOME!

@kasemir
Copy link
Collaborator

kasemir commented Feb 17, 2022

Thanks for the info! Way back, I created that phoebus.bat based on the phoebus.sh without knowing much about the specifics of Windows, which I hardly use. @shroffk or somebody else who actually uses Windows, can you check this?

@shroffk
Copy link
Member

shroffk commented Feb 17, 2022

@kurup thanks... Do you want to open a PR and I can check this and merge it :)

@kurup
Copy link
Contributor Author

kurup commented Feb 17, 2022

@shroffk yes I'll do this.

kurup added a commit to kurup/phoebus that referenced this issue Feb 18, 2022
shroffk added a commit that referenced this issue Feb 21, 2022
@kasemir kasemir closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants