Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated publicKey field description #55

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

sourgrasses
Copy link
Contributor

Changes introduced with this PR

The "getting started" description of authentication server implementation still says the public key will show up base64-encoded and in wire format, but it looks like that was deprecated.


By contributing to this repository, I agree to the contribution guidelines.

@tsipinakis
Copy link
Member

Hi thanks for the contribution!

DCO is failing, which means you're missing the Signed-Off-By field in your commit. git commit --amend -s should fix it. See https://github.com/ContainerSSH/containerssh.github.io/pull/55/checks?check_run_id=26238821123

@sourgrasses
Copy link
Contributor Author

Whoops, that should be fixed now.

@tsipinakis
Copy link
Member

LGTM thanks! :)

@tsipinakis tsipinakis merged commit c1623c5 into ContainerSSH:main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants