-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decision Proposal 70 - May 2019 Draft API Standards Feedback Cycle 1 #70
Comments
Hi James, Re:
|
Hi James, Copied across from #67 (comment) Product API header values Request
Response
Unless the intention is otherwise? Additionally we notice that x-Correlation-Id is specified in the response header, but not in the request header documentation. Thanks. |
Re: Eligibility OTHER 'Use of additionalValue Field' = 'NA' but still optionalHi James/Brian, For all our OTHER eligibility type cases we have descriptive text for This also fits the pattern throughout the standards where We propose that the Eligibility enums table entry for 'OTHER' has a 'Use of additionalValue Field' value of 'NA'. Could you please confirm that this still permits us to provide a value if required i.e. it should not be interpreted as 'must not be provided'. The inclusion of 'Mandatory if the eligibilityType field is set to OTHER' in the Clearly we can repeat the descriptive text in Thanks |
Commonwealth Bank welcomes the opportunity to provide feedback on version 0.9.3 of the Draft API Standards. |
VersioningThe documentation versioning strategy is currently incompatible with the end point versioning strategy. This is because breaking changes are not always negotiated. To illustrate this, consider the following sequence:
In this example, there is currently no mechanism for the client and server to negotiate which version of the security standard is to be used. Presumably, the client would assume that v1.2.0 was to be used, and the server would use v1.3.0. Even though the Data Holder’s server has implemented endpoint versioning correctly the Data Recipient might be unable to communicate in this instance. We suggest two possible solutions to these problems. Both solutions require:
Sunset headers and/or some other form of depreciation notification may also be useful for Data Consumers. A breaking change is a change which is not backwards-compatible. Backwards-compatible changes include:
The definition of a breaking change should be included in the standard. Solution 1 – Block Versioning without endpoint versioningWe support this solution. The standards would be block versioned without endpoint versioning. This should allow, and stipulate, that any changes made to endpoints within the block version MUST be backward-compatible otherwise the block version number is incremented. This would be split by industry into authenticated endpoints, unauthenticated endpoints and (as was the case until recently) into the infosec profile. This approach is already being used in practice by all of Data61’s streams in the lead up to the release of version one. Artefacts using this strategy include:
This approach supports Principle 4 (APIs provide a good developer experience) because it:
Additionally, we believe that this approach may be the most pragmatic if there are large differences in the standards between industries. Solution 2 – Minor version changes are always non-breakingMinor version changes would be non-breaking in this standard. This would allow a data recipient to mix and match endpoint versions using the header negotiation method. We do not support this solution. It does not provide a good developer experience because:
ReauthorisationIt is difficult to comment on the reauthorisation flow until a decision is made on the authorisation flow. This is because we believe the two decisions are interlinked. Noting that few customers will have a need to reauthorise on February 2020, our recommendation also depends on the timeframe with which reauthorisation must be implemented. If reauthorisation must be implemented for February 2020, our recommendation is that the reauthorisation flow should follow the same approach as the authorisation flow. If it need not be implemented for February 2020, then the decision should be deferred until the authorisation flow approach is clear. Customer Endpoint
|
Error object Currently in the payload conventions: https://consumerdatastandardsaustralia.github.io/standards/#payload-conventions It is stated that: If the response is unsuccessful (not 200 OK) the root object: MUST contain an errors object As per our discussion this payload isn't required for all non-200 responses - only for specific scenarios. NFRs With regards to the NFR document which threshold does get account balance and the scheduled payments fall in? We are assuming the low threshold, if so could this be reflected in the document? |
HTTP Headers
Authorisation scopes Account creation date isPreferred flag for phoneNumbersand emailAddresses objects Get Metrics API alignment to Decision 21 paymentSet in Scheduled Payments type Description of amount in Scheduled Payments |
Hi All, this is the new persona for the CDR API Stream that will be used for posting by the Data Standards Body. You can expect to see more interactions from this profile as we continue to progress. Thank you all for the contributions to date for this consultation. The consultation period is now complete and this thread will be closed for further posting. The submissions provided via email will be added here, however. A new thread for holistic (API and InfoSec) feedback will be opened shortly for ongoing feedback. |
Please find attached the feedback submission received from the Australian Banking Association |
Please find attached the feedback submission received from AGL |
Please find below the feedback submission received from ARCA (excerpt of email received) Here’s our feedback on the data standards:
|
Please find attached the feedback submission received from BPAY |
Please find attached the feedback submission received from ID Exchange |
Please find attached the feedback submission received from FinTech Australia |
Please find attached the feedback submission received from Visa |
Please find attached a summary of the feedback received for the May draft across API standards and InfoSec streams. This document has been used to help focus discussions amongst participants and to assist the Chair in making the decisions arising from the consultation process. This document has also been provided to the Advisory Committee for review and discussion in the July 10th meeting. |
Please find attached the approved decision document responding to the majority of the feedback in response to the May 2019 draft standards. Note that decisions for Consent and Authorisation Flow will be published separately. (note: minor wording update to the attached document made 10:17am 15th July) |
This thread has been created to accept feedback on the May 2019 working draft. Specifically this thread is for feedback on the overall standards, API URIs and payloads.
We will also receive written submissions on this update on the basis that such submissions will be published subsequently. In accordance with our normal transparency policy all submissions will be made public. Written submissions should be submitted via the CDR email address: [email protected].
Where participants believe they have sensitive information to convey we will consider those discussions and give guidance on our preferred disclosure approach prior to meeting to discuss such issues. To discuss such issues please email us at the CDR email address: [email protected].
We will written submissions and feedback on this thread until Friday 21st June.
For feedback on the Information Security Profile please refer to the separate thread at #71.
The text was updated successfully, but these errors were encountered: