-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iteration 12 Holistic Feedback #530
Comments
A reminder that was lost in MI11, can the "effective date" used for |
Sorry we missed that one @perlboy, we'll pick it up in this iteration |
It was noted via a Zendesk ticket that some of the statements in the FDO section of the standards user |
The items in the Register Dependency Schedule should be shown in ascending order as per the FDO table. |
There is a documentation typo in ResponseOpenIDProviderConfigMetadata, there are escaped quotes around |
Review the Future Dated Obligations table - consider removing or greying-out items past their due date. |
The Profile Scope Data Language link in the Future Dated Obligations table is currently broken and should point to Profile Scope and Standard Claims: Common. |
Some parameters in the following sections specify field types that are not aligned to the Common Field Types definitions -
The details have been acknowledged in the Known Issues list since v1.13.0 (Register APIs use different field type definitions). |
Response Headers in the Energy APIs section (under Get Generic Plans for example) show These could be aligned to the convention used in the Banking APIs Response Headers (Get Accounts for example). |
There is a typo 'ofways' in the Standards README - |
AEMO have stated that the description of
|
Doesn't this fundamentally alter the meaning of this field? Does this mean that service points that are older than 2 years will now have a |
1.19.0 was just released but introduced |
I agree that's an issue. For background, we raised a question to clarify how this field should be populated and what a valid service point is. We have performance concerns if we need to retrieve records that are up to 20 years old to determine the original date a service point was created (which may or may not be a defaulted date), as we need 2 years of standing data to support usage APIs it was suggested that we could default the date if the service point was created more than 2 years prior. Looking at previous consultation on this, it seems to have been suggested that the validFromDate would be the latest start date for service point details. So essentially validFromDate would be the effective date of the current set of service point details and the lastUpdateDateTime would be the date on which they were modified last. We would be happy to align with this option if preferable. " “vaildFromDate”: the latest start date of the constituent data sets. |
Hmmm, I would have thought this data would be in a materialised view and not retrieved live, if it is live it will fail an NFR very quickly in an O(n2) problem as demand increases. Ultimately this is an implementation concern, I don't think it's appropriate to be altering the Standard because this isn't being persisted by the source system. As per above, I get if this was once off but the rolling forward thing means that most service points, cause most are older and unchanged >2 years, will essentially be considered to have a transient value, this could actually exacerbate load from Data Recipients. At a minimum it basically guarantees that the range queries from a retailer won't align with what the Data Recipient is going to get back in this field.
So the above was feedback from AEMO at the time but the DSB response was:
What's interesting with that statement is that I can't actually find Ultimately, from an implementation perspective I guess it doesn't matter ("a date is a date") but from a Data Recipient perspective how do they find out how old a meter is? That seems like a useful data point that I presumed was the purpose of this field? |
There is no such field in MSATS. We have effective from/to and updated/created dates on all standing data records which tell you what date range the information is effective for and when it was created / updated. You would not be able to tell how old a meter is by us providing a single date for when the service point was created in MSATS. Meters change over time and won't align with dates for when the service point was created or updated. Also service points are created in advance of supply being connected or metering being installed so the date on which it was created doesn't mean anything to consumers. |
Thanks @perlboy this has been identified and corrected in the 1.19.0 release. |
This is valid feedback.
This would be a better approach as it aligns with the original intent of the field. The description can be updated as below:
|
This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@b56b952 |
These changes have been staged for review: ConsumerDataStandardsAustralia/standards-staging@76168ea |
These changes have been staged for review: ConsumerDataStandardsAustralia/standards-staging@6db91d1 |
This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@e63e85e |
This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@b56b952 |
This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@a806d41 |
Given the size of this change and need for closer review, this issue has been converted to a change request: #546 |
This change has been staged for review: ConsumerDataStandardsAustralia/standards-staging@79303fa |
This fix has been staged for review: ConsumerDataStandardsAustralia/standards-staging@8713da2 |
This fix has been staged for review: ConsumerDataStandardsAustralia/standards-staging@57c6043 |
This fix has been staged for review: ConsumerDataStandardsAustralia/standards-staging@8a53ea2 |
This CR has been created to simplify the raising of minor changes, such as text corrections or description clarifications, that are not really material to the standards but do have real impact of readability and clarity.
Please raise any such suggestions that you would like included in Maintenance Iteration 12 and the DSB will review them. If we believe the suggestion are material we will raise a dedicated CR for them.
The text was updated successfully, but these errors were encountered: