Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnergyPlanDiscounts contains optional fields that should be conditional #448

Closed
joe-aer opened this issue Dec 16, 2021 · 2 comments
Closed

EnergyPlanDiscounts contains optional fields that should be conditional #448

joe-aer opened this issue Dec 16, 2021 · 2 comments
Labels
Energy

Comments

@joe-aer
Copy link

joe-aer commented Dec 16, 2021

Description

The following fields of the EnergyPlanDiscounts object are marked as optional when they should be conditional based on the value of the methodUType field:

  • percentOfBill
  • percentOfUse
  • fixedAmount
  • percentOverThreshold

Area Affected

This change will affect the EnergyPlanDiscounts object returned by the Get Generic Plan Detail endpoint.

Change Proposed

The proposed change is for these fields to be marked as conditional, both in documentation and in the Energy Swagger docs.
@CDR-API-Stream
Copy link
Collaborator

These changes have been staged for review: ConsumerDataStandardsAustralia/standards-staging@release/1.16.1...maintenance/448

@CDR-API-Stream
Copy link
Collaborator

This change was incorporated into release v1.17.0. Refer to ConsumerDataStandardsAustralia/standards#237 for further details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Energy
Projects
Data Standards Maintenance
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CDR-API-Stream @joe-aer