-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standard requires customer's cookies for logging in to data recipient to be provided to data holder #28
Comments
Based on: It seems the intention was actually to include all the users headers. It seems that two changes are necessary:
|
As referenced, the intent was to include all user headers and was to support risk scoring for fraud detection. The two additional comments are reasonable and we will consider this issue for inclusion in the current maintenance iteration. The current text is explicit that only standard http headers are to be included which is a white list as the list of standard headers is well known. Rather explicitly state this list a clarification that security and authentication headers for the original service may be excluded by the data recipient may be preferred. This leaves the inclusion of these headers at the discretion of the data recipient. |
What benefit is intended to be derived from shipping headers of the data recipients preference? I understand the reasoning for sending browser user-agent details as this is useful for WAF signature analysis (particularly correlation across platforms) but essentially all other headers are mostly only relevant for the interaction between an end users browser and the data recipients service. Specifically on "well known standard headers" this is open to high degrees of interpretation. For instance the Outside of a browsers user agent the standards should either explicitly call out what headers they are expecting to be shipped or not require any additional ones at all. From my perspective I don't see what other headers would be useful. |
Based on the provided feedback the language defining the headers to be included will be amended to indicate that all client headers should be included except:
|
NAB doesn't support the general definition currently provided for what headers should be included. In order for NAB to provide effective fraud monitoring, the following headers are required at a minimum:
|
@NationalAustraliaBank That's not a list of HTTP headers, and some (geo location data, device type, etc) is information NAB should be determining from other info already supplied (IP address, user agent, etc). Other data (e.g. screen size) NAB can collect itself at the Authorization Endpoint. |
I'll add onto @jogu comments here and highlight that the |
Description
The current draft says this about x-cds-User-Agent:
I presume this isn't what's intended, as it would require the data recipient to send the 'Cookie' header that the customer used to access the data recipient. Access to that cookie header would likely let the data holder impersonate the customer and access the data recipient's service, exposing various PII included that received from other data holders, which is not something the data holder should have the ability to do.
Area Affected
https://consumerdatastandardsaustralia.github.io/standards/#http-headers
Change Proposed
Change to simply 'The customer's original User Agent header'. (I don't see any clear reason why base64 encoding would be required or helpful.)
The text was updated successfully, but these errors were encountered: