Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour where posted transactions only have an associated date. #173

Open
WestpacOpenBanking opened this issue Mar 30, 2020 · 3 comments
Labels
Banking Banking domain APIs

Comments

@WestpacOpenBanking
Copy link

Description

Currently postingDateTime in BankingTransaction has a type of DateTimeString. Frequently, only the date of posting is recorded without an associated time. Data recipients are likely to treat those transactions as if they occurred at a certain time in a certain time zone with the same date. However, this choice is arbitrary with many possible choices. This issue is particularly problematic in relation to the filtration of results from Get Transaction For Account endpoint using the oldest-time and newest-time query parameters – unexpected behaviour may occur if Data Recipients filter based on date and time (transactions that appear to be from the wrong day, for instance).

Area Affected

The primary field which is affected is postingDateTime in BankingTransaction. There may be similar issues with valueDateTime and executionDateTime, or in other cases where the DateTimeString is used (especially in conjunction with filtration).

Change Proposed

We recommend that the standard specify that posted transactions that only have a recorded date and not an associated time should be deemed to have occurred at a certain time e.g. 2:00 am AEST on the same day). This change would likely need to be future dated as different data holders may have already implemented inconsistently.

@perlboy
Copy link

perlboy commented Mar 31, 2020

DateTimeString includes a time zone so recipients will treat it according to the timezone it is presented in. This aside, it does seem valid to at least clarify what the "default time if not available" value should be especially since the description is This is the time that appears on a standard statement which, as far as I'm aware, zero banks print times on their "standard statements".

Normal convention would be 0:00 UTC (ie. epoch at the first second of the day) although I accept there's no specific "standard" to this.

@nils-work
Copy link
Member

For reference, timezone-related concerns have also been raised in #539, and explored in relation to energy endpoint date filtering in the last block of this comment.

@nils-work
Copy link
Member

As this issue could be relevant to changes being considered in MI19 (#636), is it still a valid concern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Banking Banking domain APIs
Projects
Status: Full Backlog
Development

No branches or pull requests

4 participants