-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance tracker #8851
Performance tracker #8851
Conversation
9dc69bf
to
9824c61
Compare
...main/java/tech/pegasys/teku/validator/coordinator/performance/DefaultPerformanceTracker.java
Show resolved
Hide resolved
...main/java/tech/pegasys/teku/validator/coordinator/performance/DefaultPerformanceTracker.java
Outdated
Show resolved
Hide resolved
7fc472a
to
786b9dd
Compare
I run some benchmarks to compare the old and the new attestations performance algorithm and the results are encouraging. Old Version Phase0 Attestations
Doesn't work for the electra attestations, so no Electra attestations benchmarking New Version Phase0 Attestations
Electra Attestations
Context:
Observations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we'll need to cherrypick this to the mekong branch too just remember... |
PR Description
Update the performance tracker to support the new Electra attestation aggregation logic.
This prevents a memory leak triggered in Electra.
Fixed Issue(s)
Fixes #8847
Documentation
doc-change-required
label to this PR if updates are required.Changelog