Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt engineGetBlobs #8663

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Adopt engineGetBlobs #8663

merged 8 commits into from
Oct 2, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Sep 30, 2024

This PR implements:

  • query to local el via engine_GetBlobsV1 when blobs are missing. If blobs are still missing after the query, RPC request will be triggered against remote peers asking for remaining blobs
  • when a blob is successfully recovered via local el, than it will be published over p2p. This is the reason why the blob_sidecar is fully reconstructed when interacting with local EL.

fixes #8622

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr marked this pull request as ready for review October 2, 2024 17:25
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit 4b204e4 into Consensys:master Oct 2, 2024
17 checks passed
@tbenr tbenr deleted the use-engineGetBlobs branch October 2, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for engine_getBlobs
2 participants