implement POST /eth/v1/validator/sync_committee_subscriptions for altair
#3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltair fixes Consensys#3907 Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
…plemented. Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
ajsutton
reviewed
May 4, 2021
Comment on lines
60
to
68
| public static SyncCommitteeSubnetSubscription create( | ||
| tech.pegasys.teku.api.schema.altair.SyncCommitteeSubnetSubscription schemaSubscription) { | ||
| return new SyncCommitteeSubnetSubscription( | ||
| schemaSubscription.validatorIndex.intValue(), | ||
| schemaSubscription.syncCommitteeIndices.stream() | ||
| .map(UInt64::intValue) | ||
| .collect(Collectors.toList()), | ||
| schemaSubscription.untilEpoch); | ||
| } |
There was a problem hiding this comment.
I'm not real keen on the REST API objects bleeding into the internal objects like this. Previously we've had a .toInternal() on the API object so it could go the other way.
There was a problem hiding this comment.
the thing is the validator objects go both ways and this is way simpler than the resulting code if we don't do it. but i guess i'll change it.
Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3907
Signed-off-by: Paul Harris [email protected]
Documentation
documentationlabel to this PR if updates are required.Changelog