Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make execution_optimistic required field in GetProposerDuties #7053

Closed
StefanBratanov opened this issue Apr 18, 2023 · 2 comments · Fixed by #7054
Closed

Make execution_optimistic required field in GetProposerDuties #7053

StefanBratanov opened this issue Apr 18, 2023 · 2 comments · Fixed by #7054
Assignees
@StefanBratanov

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Apr 18, 2023 •
edited
Loading

Currently, if execution_optimistic is false, It is not included in the json response. To make it consistent with the attester and sync duties endpoints, It would be preferred to include it.

https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/ValidatorRequiredApi/getProposerDuties
@StefanBratanov StefanBratanov self-assigned this Apr 18, 2023
@StefanBratanov StefanBratanov mentioned this issue Apr 18, 2023
Merged
2 tasks
@mehdi-aouadi
Copy link
Contributor

As you mentioned and according to the spec the ExecutionOptimistic is assumed to be false when not present. So not really an issue on our side but on the caller side...
Being consistent with the other endpoints could be considered a good reason so I guess it's ok to include it in any case

@StefanBratanov
Copy link
Contributor Author

As you mentioned and according to the spec the ExecutionOptimistic is assumed to be false when not present. So not really an issue on our side but on the caller side... Being consistent with the other endpoints could be considered a good reason so I guess it's ok to include it in any case

Yup, I agree. I wouldn't have changed it, but then saw for the other endpoints is required field so decided to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBratanov StefanBratanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make execution_optimistic required field in GetProposerDuties StefanBratanov/teku
2 participants
@mehdi-aouadi @StefanBratanov