Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge] Support authentication for the Engine API #4958

Closed
ajsutton opened this issue Feb 8, 2022 · 2 comments · Fixed by #4980
Closed

[Merge] Support authentication for the Engine API #4958

ajsutton opened this issue Feb 8, 2022 · 2 comments · Fixed by #4980

Comments

@ajsutton
Copy link
Contributor

ajsutton commented Feb 8, 2022

Description

Support authentication for engine API as per ethereum/execution-apis#167

@arhamj
Copy link
Contributor

arhamj commented Feb 11, 2022

If not already picked, I could pick this @ajsutton

Sub tasks I would be splitting this into:

  1. Adding a CLI command to get/generate the 256 bit key
  2. Adding auth header to EL APIs

(1) is fairly straight forward. For (2) I'm looking at the following design:

  1. Implementing a TokenProvider which takes care of the generation of the JWT token as per specs
  2. Implementing a wrapper for TokenProvider to make it thread safe by introducing a reentrant lock
  3. Adding an OkHttp client interceptor consuming an instance of the SafeTokenProvider to add the auth header to intercepted requests

@ajsutton
Copy link
Contributor Author

Work hasn't started in this yet but it is next on our priority list and we'll need to get it wrapped up probably early next week.

If you're able to start on it and ok with us taking where you're up to and finishing it off if need be next week that would be great. Might just be more of a tag team development effort than usual. That usually works well as long as we ensure we push up any work as a draft pr and merge things in as small steps as much as possible.

You're plan for how to approach it sounds good and getting the cli args added would be a great first pr. We'd make them --X options and mark them hidden for now like the other merge options until we're ready for official merge support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants