New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix committee assignment bugs (Spec PR #699) #478

Closed

akhila-raju opened this issue Mar 15, 2019 · 0 comments

Labels

bug 🐞 good first issue 🙋

Contributor

akhila-raju commented Mar 15, 2019

Description

Fix these two bugs:

We were modifying current_shuffling_epoch and then calling get_current_epoch_committee_count expecting that it was still getting the committee count from the previous value of current_shuffling_epoch. Switch operations to prevent this error
When getting next epoch committee assignments, we were sometimes modifying committees_per_epoch and shuffling_epoch when these things should have remained constant.

See Spec PR #699

akhila-raju added the bug 🐞 label

akhila-raju self-assigned this

akhila-raju added this to the Beacon Chain v0.5.0 Spec milestone

akhila-raju removed their assignment

akhila-raju added the good first issue 🙋 label

jrhea closed this as completed

jrhea mentioned this issue

Update to spec v5.1 #637

Closed

26 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment