feat: Support RON and JSON bin formats
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the default `serde::Deserializer` for `ColumnRef` and `Handle`. These are now serialised as strings only. The reason for this is that the JSON serialiser cannot otherwise handle either of these items being used as _keys_ for a map.
DavePearce
deleted the
221-support-both-ron-and-json-bin-formats-together
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ability to generate
JSONbinfiles was hidden behind a build feature. Hence, you needed to build the binary specifically for generatingJSONbinfiles. The primary reason for this is that supporting bothRONandJSONformats in the same binary required breaking changes to the format. However, the time has come to address this and support both formats. At this time,RONremains the default choice --- but this will be deprecated in the very near future.