Fix: Incorrect Trace Construction #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a command-line interface to the `CGO` API. The purpose of this is to enable simple testing from the command line.
This puts in place an almost complete fix for #201. Specifically, instead of constructing `ComputedColumn`s for columns, it now does a very similar process for registers. This is not the most efficient approach, as it requires searching for the columns allocated to a given register. Then, it determines the padding value for all columns and checks they match. However, improving this would require more invasive changes which are out-of-scope at this time. One issue remains however. Specicifically, there appear to be registers which are not associated with any column. I'm not sure how this could arise, or what's going on here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts through a fix for the construction of
Trace(which is used in theCGOAPI). Specifically, it was not enumerating registers. Rather it was enumerating columns, which lead to mismatches between the trace file and expected columns.