Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise Spillage Computation #142

Open
DavePearce opened this issue May 15, 2024 · 1 comment
Open

Optimise Spillage Computation #142

DavePearce opened this issue May 15, 2024 · 1 comment

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented May 15, 2024

(see also #139 and #151)

Currently more spillage is being requested than necessary. For example, in this case:

(defconstraint test1 () (eq! A (next B)))

The tool is reporting a spillage value of 1 because we have a positive shift. However, since padding is only ever added at the beginning of a trace, it is only negative shifts that require spillage (see #139 for details on how to fix this).

In addition, its not clear to me that the above example requires any spillage at all. Spillage seems to me to only be required for computed columns. Therefore, we could report the required spillage for the above as 0. However, its unclear to me exactly how best to implement this optimisation. Presumably, we could do the spillage calculation just on computed columns for example.

@delehef
Copy link
Contributor

delehef commented May 16, 2024

Spillage seems to me to only be required for computed columns.

Basically, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants