Fix Default Base for Interleaved Constraints #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the default base for the column(s) arising from an interleaved constraint to be hexadecimal rather than decimal. This now follows the convention used in e.g. `defcolumns` which also defaults to hex.
DavePearce
deleted the
112-corset-inspect-display-display-bytes-in-little-endian-order
branch
delehef
reviewed
Apr 10, 2024
| @@ -207,7 +207,7 @@ impl std::convert::TryInto<DisplayableColumn> for ColumnAttributes { | |||
| } | |||
| Ok(DisplayableColumn { | |||
| name: self.name, | |||
| base: self.base.get().cloned().unwrap_or(Base::Dec), | |||
| base: self.base.get().cloned().unwrap_or(Base::Hex), | |||
There was a problem hiding this comment.
This could be replaced by implementing Defautl for Base and using unwrap_or_default() everywhere a similar use case appears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the default base for the column(s) arising from an interleaved constraint to be hexadecimal rather than decimal. This now follows the convention used in e.g.
defcolumnswhich also defaults to hex.