Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about test file #148

Open
alien315 opened this issue Jan 9, 2019 · 0 comments
Open

Question about test file #148

alien315 opened this issue Jan 9, 2019 · 0 comments

Comments

@alien315
Copy link

alien315 commented Jan 9, 2019

Just curious but in your test file you have:

// should approve max of msg.sender & withdraw 20 without changing allowance (should succeed).
it('approvals: msg.sender approves accounts[1] of max (2^256 - 1) & withdraws 20', async () => {

Why this test should succeed? is not a bug that a token holder can withdraw without changing the allowance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant