Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use bash for preview if main shell is fish #5

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

DanielVoogsgerd
Copy link
Contributor

If the main shell is fish, the stdin redirection for preview fails. We
can set the shell to bash so FZF starts bash instead.

Fixes: #4

If the main shell is fish, the stdin redirection for preview fails. We
can set the shell to bash so FZF starts bash instead.
@ConnerWill ConnerWill self-requested a review February 26, 2024 21:34
@ConnerWill ConnerWill self-assigned this Feb 26, 2024
@ConnerWill
Copy link
Owner

Looks good! thank you :) @DanielVoogsgerd

@ConnerWill ConnerWill merged commit 0135be8 into ConnerWill:main Feb 26, 2024
1 check failed
@ConnerWill ConnerWill added the bug Something isn't working label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid redirection target on fish shell
2 participants