Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect UI state after failed connection. #12

Open
oleksii-frolov opened this issue Dec 10, 2014 · 2 comments
Open

Incorrect UI state after failed connection. #12

oleksii-frolov opened this issue Dec 10, 2014 · 2 comments
Assignees
Labels

Comments

@oleksii-frolov
Copy link
Contributor

When connection is failed the upper right button is shown like application is connected, if user change tabs and returns to media tab all buttons (photo, video, audio) are enabled, but of course they don't work because there is no active connection.

@oleksii-frolov oleksii-frolov changed the title Incorrect UI state after failed connection. When connection is failed the upper right button is shown like application is connected, if user change tabs and returns to media tab all buttons (photo, video, audio) are enabled, but of course they don't work because there is no active connection. Incorrect UI state after failed connection. Dec 10, 2014
@oleksii-frolov oleksii-frolov self-assigned this Dec 11, 2014
@khk624
Copy link
Contributor

khk624 commented Dec 15, 2014

The commit looks okay, but I could not reproduce this issues. How did you reproduce this?
My step was,

  1. Open sampler
  2. Connect to Chromecast, or netcastTV
  3. Turn off Netcast or unplug the cable
  4. Wait for a minute, and then sampler shows "Device disconnected"
  5. move tabs to Web App Page
  6. move tabs back to Media Page

Result: Everything is disabled.

@oleksii-frolov
Copy link
Contributor Author

I found this issue on Nexus 4 with Android 4.4.4 and older version of google play services library on it. It was com.google.android.gms-5.2.08. During connection to Chromecast device CastService threw ServiceCommandError because of older com.google,android.gms and it wasn't handled. And that could happen with any service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants