Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

[Feature] Skip and play automatically #44

Closed
KimPig opened this issue Jun 26, 2022 · 10 comments
Closed

[Feature] Skip and play automatically #44

KimPig opened this issue Jun 26, 2022 · 10 comments
Labels
enhancement New feature or request

Comments

@KimPig
Copy link

KimPig commented Jun 26, 2022

Describe the feature you'd like added

Skipping is normal, but automatically pauses after skipping.
I hope it plays right away without pausing.

Additional context
Add any other context or screenshots about the feature request here.

@KimPig KimPig added the enhancement New feature or request label Jun 26, 2022
@gruenfink
Copy link

Confirming this bug. A click on the button does skip the video to the correct timestamp but also pauses the video.

My initial suspicion was that the mouse click might be registered twice, as a button press and also as a click on the background video, i.e. a pause action. But if the button is clicked while already in a paused state, the video still doesn't play on its own. So it's not that.

@Nikey646
Copy link

I merged the changes from the forked web version into my own copy that had a couple other modifications, and had this issue. Effectively reverting this commit fixed my issue...

@KimPig
Copy link
Author

KimPig commented Jul 13, 2022

I merged the changes from the forked web version into my own copy that had a couple other modifications, and had this issue. Effectively reverting this commit fixed my issue...

I reverted that commit and confirmed that there was no problem. I'll fix the tag with a bug.

@KimPig
Copy link
Author

KimPig commented Jul 29, 2022

I merged the changes from the forked web version into my own copy that had a couple other modifications, and had this issue. Effectively reverting this commit fixed my issue...

I found a problem.
PlayPause works fine on PC, but it pauses when I press the button on Android.

unpause works fine on Android, but it pauses when I press the button on PC.

Is there a solution?

@ConfusedPolarBear
Copy link
Owner

Container image ghcr.io/confusedpolarbear/jellyfin-intro-skipper:28502dbd5e (built from 28502db) resolves this issue for me (tested on Firefox running on Linux and Windows).

@KimPig
Copy link
Author

KimPig commented Jul 30, 2022

Container image ghcr.io/confusedpolarbear/jellyfin-intro-skipper:28502dbd5e (built from 28502db) resolves this issue for me (tested on Firefox running on Linux and Windows).

It works perfectly with Mobile and PC.
Closing the issue.

@KimPig KimPig closed this as completed Jul 30, 2022
@CTalvio
Copy link

CTalvio commented Aug 5, 2022

Running JF native.

Skipping is still pausing the playback for me.

I downloaded the modified web client using the github actions link on the native doc page, and simply pointed my JF server to a new location for JF web with a systemd drop in.

Apparently this does not get me a version that works?

@KimPig
Copy link
Author

KimPig commented Aug 5, 2022

CTalvio

Maybe you should build with the modified code.

@sambartik
Copy link

Exactly as kimpig says. Currently you need to build it yourself to have the latest patched frontend. The GH actions link provided in the native doc page is outdated judging by the downloaded file hash suffix 4f8a2c2a96, which is the hash of a commit that comes before the mentioned 28502db commit.

@ConfusedPolarBear
Copy link
Owner

I've updated the native documentation page with instructions on how to download the latest version of the web interface.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants