Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

[Feature] Make intro time requirements configurable by the user #38

Closed
gruenfink opened this issue Jun 23, 2022 · 4 comments
Closed

[Feature] Make intro time requirements configurable by the user #38

gruenfink opened this issue Jun 23, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@gruenfink
Copy link

Show introductions will only be detected if they are:
Located within the first 25% of an episode, or the first 10 minutes, whichever is smaller

There are quite a few episodes in my library where the intro starts after the 10 minute mark. The plugin fails to detect these intros with its current hardcoded analyze duration limit of 600 seconds. It would be very much appreciated if you allowed the user to change this setting in a config file or the GUI.

Personally, I'd probably set it to 40% or 20 minutes, whichever is smaller. These values should cover nearly 100% of episodes instead of the current ~95%. The increased resource usage would be fine, since the audio-based scan is very quick and the fingerprint data require minimal disk space.

Offering just two scan options in the GUI would also provide a pretty nice user experience:

  • Quick scan (default) detects most intros (25%/10m)
  • Full scan takes twice as long and detects virtually all intros (40%/20m)
@gruenfink gruenfink added the enhancement New feature or request label Jun 23, 2022
@conkydong
Copy link

Recently I watched the new episodes of „Evil (2019)“. Sometimes the intro even starts at 20:30 or later.

@gruenfink
Copy link
Author

Recently I watched the new episodes of „Evil (2019)“. Sometimes the intro even starts at 20:30 or later.

IMDb lists the runtime of this show as 42min. To capture outliers like these we would need to increase the time constraints to something like 60%/30m, or just drop the limit altogether and scan entire episodes for full coverage.

@ConfusedPolarBear
Copy link
Owner

This is being worked on in the custom-analysis branch.

@ConfusedPolarBear
Copy link
Owner

This feature has been merged into the main branch and will be released as part of v0.1.6 (beta version).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants