Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

[Bug] Episodes are not ordered correctly within season #25

Closed
Flo56958 opened this issue Jun 18, 2022 · 1 comment
Closed

[Bug] Episodes are not ordered correctly within season #25

Flo56958 opened this issue Jun 18, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Flo56958
Copy link

Describe the bug
The episodes to be analyzed are ordered by the sorting title instead of the episode number (index number).

As seen by this code segment:

OrderBy = new[] { ("SortName", SortOrder.Ascending) },

This leads to bad intro detection in certain seasons. For example, one season I've tested has 64 episodes and changes the intro every 12-15 episodes. As the episodes are scrambled by sorting after the sorting title and not chronological, the plugin compares wrong intro sequences and finds no timestamps (tested on small subset of 5 episodes). After testing I have found that changing "SortName" to "IndexNumber" in the mentioned line solves the wrong sorting and results in 100% intro detection within the tested episodes. It would also fix the Fingerprint Visualization interface as it uses the same sorting from the same list.

Is there a reason for sorting with the title instead of chronological?

System information

  • Plugin version: latest master commit f6abe81
  • Jellyfin version: 10.8.0
  • Jellyfin installation method: Native (Service)
  • OS: Windows 11
@Flo56958 Flo56958 added the bug Something isn't working label Jun 18, 2022
@ConfusedPolarBear ConfusedPolarBear self-assigned this Jun 18, 2022
@ConfusedPolarBear
Copy link
Owner

Thank you for the very detailed bug report & root cause analysis. I just tested this change locally and didn't see any negative side effects, so I'll go ahead and change the plugin to use the new sort order.

Is there a reason for sorting with the title instead of chronological?

None of the code that I had seen previously had sorted by that field.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants