Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle Events #954

Merged
merged 10 commits into from
Mar 22, 2023
Merged

Lifecycle Events #954

merged 10 commits into from
Mar 22, 2023

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Mar 20, 2023

Description

This PR is the follow-up to ConduitIO/conduit-connector-protocol#22, where connector lifecycle events were added to the connector protocol. In this PR we expose those methods in Conduit so it can produce these events (coming in the next PR).

Fixes #937

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon changed the title WIP: Lifecycle Events Lifecycle Events Mar 20, 2023
@lovromazgon lovromazgon marked this pull request as ready for review March 20, 2023 15:47
@lovromazgon lovromazgon requested a review from a team as a code owner March 20, 2023 15:47
pkg/plugin/builtin/v1/destination.go Outdated Show resolved Hide resolved
pkg/plugin/builtin/v1/destination.go Outdated Show resolved Hide resolved
pkg/plugin/plugin.go Outdated Show resolved Hide resolved
@lovromazgon lovromazgon requested a review from maha-hajja March 21, 2023 12:51
@lovromazgon lovromazgon merged commit 00ccd81 into main Mar 22, 2023
@lovromazgon lovromazgon deleted the lovro/lifecycle-events branch March 22, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLE: Support lifecycle events in Conduit
2 participants