Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests #1970

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Add more unit tests #1970

merged 7 commits into from
Nov 12, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Nov 12, 2024

Description

TBD

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review November 12, 2024 14:06
@hariso hariso requested a review from a team as a code owner November 12, 2024 14:06
@hariso hariso self-assigned this Nov 12, 2024
raulb
raulb approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thank you @hariso

@hariso
Copy link
Contributor Author

hariso commented Nov 12, 2024

Lovely. Thank you @hariso

Thank you for the review!

@hariso hariso merged commit 5c42c30 into main Nov 12, 2024
3 checks passed
@hariso hariso deleted the haris/more-tests branch November 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees

@hariso hariso

Labels
None yet
Projects
Conduit Main
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @raulb