Validate connector name and pipeline description through API #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovromazgon
reviewed
Oct 18, 2023
There was a problem hiding this comment.
I would move these validations at least into the orchestrator, if not into the actual services. For example, we already check that the pipeline has a name here, I'd keep these validations there. This way the check is executed even if Conduit is used as a library (without endpoints).
lovromazgon
reviewed
Oct 30, 2023
lovromazgon
reviewed
Oct 31, 2023
…ctor service_test.go
…i' into adam/validate-connector-names-api
increase delay in persister_test.go
lovromazgon
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Good work! I'm approving in advance, even though I left a few more nitpicks. Thanks @AdamHaffar 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds validation for the following config values:
Fixes #574
Quick checks: