-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Consider swapping Goja with Sobek #1902
Comments
I don't think we will switch just now, mainly for 3 reasons - I think it's too early to tell that the fork will be better maintained than the original repo, it does not solve any particular pain point that we are experiencing, and we already invested time into a more performant approach using standalone processors based on WASM for power users. I'll keep this issue open though and we can keep an eye on how things develop. |
That's fine. Though
Anyway, hopefully you'll consider it at some point! |
Here's their progress on adding up to ES2024 compatibility However, it might not actually be possible to implement this in Conduit. Sobek's readme says
Its probably also why it required a larger effort to add ESM to k6, rather than just swapping goja with sobek. |
I did just find this from goja for providing nodejs compatibility - not sure to what degree it could be used in conduit. https://github.com/dop251/goja_nodejs |
Feature description
The grafana/k6 team forked Goja because, among other reasons, their PR to add ES Modules support to Goja sat in limbo for far too long.
dop251/goja#430
They clearly have much more resources and motivation than Goja's dev, so it seems that Sobek is the way forward for JS in Go. K6 is already using it in their quite mature and demanding Production environment. It would be great if Conduit could leverage it!
The text was updated successfully, but these errors were encountered: