Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove long_polling #153

Merged
merged 11 commits into from
May 23, 2024
Merged

feat: remove long_polling #153

merged 11 commits into from
May 23, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented May 23, 2024

Description

Fixes #151

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb marked this pull request as ready for review May 23, 2024 16:16
@raulb raulb requested a review from a team as a code owner May 23, 2024 16:16
README.md Show resolved Hide resolved
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @raulb ! Let me know what you think about removing cdcMode completely.

@raulb raulb requested a review from lovromazgon May 23, 2024 17:48
@raulb raulb merged commit 62feffe into main May 23, 2024
3 checks passed
@raulb raulb deleted the remove-long-poll branch May 23, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CDC mode long_polling from configs and docs
3 participants