Topic profile hdf5 2 #280
Merged
Topic profile hdf5 2 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- (currently not working !) - add gasFromHdf5 - add gasSetup/Teardown methods to all gas configs - pass fieldTmp to kernel during initialization
- different access to DataBox fixes pure virtual error - use stricter types in gasSetup - remove unused gasTeardown - use intermediate buffer for hdf5 initialization - update copyrights
- passes current VirtualWindow to gasSetup - support gas offset in png2gas
Closed
| @@ -165,7 +165,7 @@ | |||
| * @param other the DeviceBuffer to copy from | |||
| */ | |||
| virtual void copyFrom(DeviceBuffer<TYPE, DIM>& other) = 0; | |||
|
|
|||
|
great pull, I will just wait for @psychocoderHPC to have a look on the clean up routine once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 261 to avoid merge conflicts.