Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise plugins' openPMD usage #5171

Open
chillenzer opened this issue Oct 16, 2024 · 0 comments
Open

Modernise plugins' openPMD usage #5171

chillenzer opened this issue Oct 16, 2024 · 0 comments
Assignees
@franzpoeschel @chillenzer
Labels
component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@chillenzer
Copy link
Contributor

In discussion with @franzpoeschel we found that some of the plugins don't use openPMD optimally. For example, there are occasions where top-level attributes are re-written on each iteration (and not just at the time of creation of the series) the effect of which is implementation-defined and could corrupt the data or leave room for ambiguity.

We should take look around the plugin folder and modernise the plugins.
@chillenzer chillenzer added component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franzpoeschel franzpoeschel

@chillenzer chillenzer

Labels
component: plugin in PIConGPU plugin refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franzpoeschel @chillenzer