Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PICMI species constand dependency retrieval #5139

Open
BrianMarre opened this issue Sep 24, 2024 · 0 comments
Open

Refactor PICMI species constand dependency retrieval #5139

BrianMarre opened this issue Sep 24, 2024 · 0 comments

Comments

@BrianMarre
Copy link
Member

BrianMarre commented Sep 24, 2024

In the review of PR #5007, here chillenzer identified the constant dependency retrieval functions as overly long and suggested to replace them with something along the lines of

from functools import reduce
return reduce(set.union, (model.get_constant_dependencies() for model in self.ionization_model_list), set())

Originally posted by @chillenzer in #5007 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant