-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log level parsing from env #836
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @angrybayblade, here are examples of how you can ask me to improve this pull request: @Sweep Fix the CI errors. @Sweep Add unit tests for `_parse_log_level_from_env()` in `logging.py` that verify: 📖 For more information on how to use Sweep, please read our documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to fd0dfb0 in 11 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. python/composio/utils/logging.py:108
- Draft comment:
Ensure thatlevel.lower()
is used consistently when accessing_LEVELS
to avoid case sensitivity issues. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_1j5fKTU4WJyYbYh0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 789c391 in 10 seconds
More details
- Looked at
14
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. python/composio/tools/base/abs.py:255
- Draft comment:
Ensure that the description is split correctly at '<<DEPRECATED' to exclude deprecated parts from the length check. This change is logical and aligns with the intent to handle deprecated descriptions. - Reason this comment was not posted:
Confidence changes required:0%
The change in the PR is related to handling deprecated descriptions. The current implementation splits the description at '<<DEPRECATED' and uses the first part. This is a logical change to ensure that deprecated parts are not considered in the length check.
Workflow ID: wflow_MngRmLxmylyALdxR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Fixes case insensitivity in log level parsing in
_parse_log_level_from_env()
inlogging.py
._parse_log_level_from_env()
inlogging.py
to handle case insensitivity by convertinglevel
to lowercase.set_metadata()
inabs.py
to handle deprecated descriptions by splitting on<<DEPRECATED
.This description was created by for 789c391. It will automatically update as commits are pushed.