Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level parsing from env #836

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

angrybayblade
Copy link
Collaborator

@angrybayblade angrybayblade commented Nov 7, 2024

Important

Fixes case insensitivity in log level parsing in _parse_log_level_from_env() in logging.py.

  • Behavior:
    • Fixes log level parsing in _parse_log_level_from_env() in logging.py to handle case insensitivity by converting level to lowercase.
  • Misc:
    • Update set_metadata() in abs.py to handle deprecated descriptions by splitting on <<DEPRECATED.

This description was created by Ellipsis for 789c391. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 11:30am

Copy link

sweep-ai bot commented Nov 7, 2024

Hey @angrybayblade, here are examples of how you can ask me to improve this pull request:

@Sweep Fix the CI errors.
@Sweep Add unit tests for `_parse_log_level_from_env()` in `logging.py` that verify:
1. Case-insensitive log level parsing works correctly (e.g., "DEBUG", "debug", "Debug" all return the same log level)
2. Invalid log levels return the default value
3. Different valid log levels are correctly parsed

📖 For more information on how to use Sweep, please read our documentation.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fd0dfb0 in 11 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/utils/logging.py:108
  • Draft comment:
    Ensure that level.lower() is used consistently when accessing _LEVELS to avoid case sensitivity issues.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_1j5fKTU4WJyYbYh0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Nov 7, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11722102353/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11722102353/html-report/report.html

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 789c391 in 10 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/composio/tools/base/abs.py:255
  • Draft comment:
    Ensure that the description is split correctly at '<<DEPRECATED' to exclude deprecated parts from the length check. This change is logical and aligns with the intent to handle deprecated descriptions.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR is related to handling deprecated descriptions. The current implementation splits the description at '<<DEPRECATED' and uses the first part. This is a logical change to ensure that deprecated parts are not considered in the length check.

Workflow ID: wflow_MngRmLxmylyALdxR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@angrybayblade angrybayblade merged commit 9897037 into master Nov 7, 2024
7 of 9 checks passed
@angrybayblade angrybayblade deleted the fix/logging-level-parsing branch November 7, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants