Merge master into main #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce From and TryFrom conversion between IBC identifier types in our fork of ibc-rs and upstream ibc-rs crate. This will be needed by Solana implementation which uses upstream code.
* adding new things to relayer documentation * adding connection toml * removing spaces * removing ips * modifying contracts
* Fix cosmos client next updates and improve some of the queries * Return in `MetricsHandler::handle_events` if no new height was found
…#478) --------- Signed-off-by: Michal Nazarewicz <[email protected]> Co-authored-by: Dhruv D Jain <[email protected]>
`verify_with_voter_set` function is performing additional validation that go beyond the [standard implementation](https://raw.githubusercontent.com/w3f/consensus/master/pdf/grandpa.pdf) (section 2.3), possibly leading to proofs not being accepted while valid. Instead, we need to accept all finality justifications where is_valid is true. The equivocations or other misbehaviors detected in the justifications must be handled too but not should not reject the proof.
Make GRPC and WS urls for cosmos optional Co-authored-by: Vladislav Markushin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull latest changes (in particular making GRPC and WS urls optional in hyperspace) from
mastertomain.