Update sebool template for bootable containers #12564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
jan-cerny
reviewed
Nov 1, 2024
matusmarhefka
force-pushed
the
sebool_bootc
branch
from
07efcbe to
0d2a030
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Bash variables whose names start with `$XCCDF_VALUE_` are valid in SCE content. The `$XCCDF_VALUE_` variables are exported by `oscap` so that the SCE check can use XCCDF Values in its code.
|
Code Climate has analyzed commit 6e1a694 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an SCE check to the sebool template for bootable containers. OVAL can't be used in this case because
selinuxbooleanprobe as currently implemented won't work inside a container as it usessecurity_get_boolean_namesfrom libselinux which checks runtime status and that is not possible in a container build environment. The new SCE check usesseinfobinary (fromsetools-consoleRPM) which checks static configuration (/etc/selinux/targeted/policy/policy.33policy file) to obtain SELinux booleans values which will be used once a container is booted.Related PR in openscap - OpenSCAP/openscap#2171