New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darknessFactor compile error #143

Open

Junder-2 wants to merge 1 commit into ComplementaryDevelopment:contribution from Junder-2:darkness-error

Junder-2 commented Oct 19, 2024 •

edited

Loading

On mc versions before 1.19 you get the error:

[14:43:47] [Render thread/WARN] [Oculus/]: Failed to resolve uniform maxBlindnessDarkness, reason: Unknown variable: darknessFactor ( = FunctionCall{max {[Id{blindness}, Id{darknessFactor}]} })
java.lang.RuntimeException: Unknown variable: darknessFactor

It doesn't seem to prevent other shaders from working but might reduce the compile time a tiny bit.


          Fixed error for older mc versions

9739d7d

Added a MC_VERSION check for darknessFactor. Shader still works without it but complain in the log.

Junder-2 changed the base branch from main to contribution

October 22, 2024 08:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet