Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot declare multiple elements #182

Open
daniel-sintef opened this issue Nov 10, 2022 · 0 comments
Open

Cannot declare multiple elements #182

daniel-sintef opened this issue Nov 10, 2022 · 0 comments

Comments

@daniel-sintef
Copy link

Latest version of n2p2 does not allow users to map to more atoms than are declared in the nnp.weights. For example in the lammps package: /lammps/examples/PACKAGES/hdnnp

Modifying the pair_coef to the following:

pair_coeff * * H O O

(And also adding an extra mass to the data.H2O-360mol data file)

Masses 
1 1.00794
2 15.9994
3 15.9994

Causes the following error:

ERROR: Element mapping is inconsistent, NNP elements: 2, emap elements: 3.

I think this error no longer makes sense anymore, as it implies the user cannot specify more mappings than there are elements. This is annoying for user cases where we wish to divide types into different regions, e.g., H H H O O O for H/O in top, middle, bottom regions respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant