Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move language diagnostics to diagnostic analyzers #432

Closed
Sergio0694 opened this issue Sep 8, 2022 · 0 comments · Fixed by #433
Closed

Move language diagnostics to diagnostic analyzers #432

Sergio0694 opened this issue Sep 8, 2022 · 0 comments · Fixed by #433
Assignees
Labels
feature request 📬 A request for new changes to improve functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements

Comments

@Sergio0694
Copy link
Member

Sergio0694 commented Sep 8, 2022

Overview

Right now, most generators are doing language version checks and emitting diagnostics. This adds a lot of overhead. All of these checks should be moved out to a dedicated diagnostic analyzer, and the generator can simply not emit code if the language version is not high enough, which can easily and quickly be validated right from the syntax provider.

@Sergio0694 Sergio0694 added feature request 📬 A request for new changes to improve functionality optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 8, 2022
@Sergio0694 Sergio0694 self-assigned this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 📬 A request for new changes to improve functionality mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant