Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowConcurrentExecution on IAsyncRelayCommand should default to false #123

Closed
michael-hawker opened this issue Feb 24, 2022 · 0 comments · Fixed by #127
Closed

AllowConcurrentExecution on IAsyncRelayCommand should default to false #123

michael-hawker opened this issue Feb 24, 2022 · 0 comments · Fixed by #127
Labels
improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change open discussion ☎️ An issue open for active community discussion optimization ☄ Performance or memory usage improvements

Comments

@michael-hawker
Copy link
Member

Talking about the new features for 8.0 more, we feel like the majority of applications aren't going to want their async commands to be fired multiple times. For instance, users may click buttons multiple times in an application, but the application probably only expects to run the command for that button a single time.

We feel like for 8.0 we should make a breaking change that all async commands only allow a single execution, and the new AllowConcurrentExecution property/option can be opt-ed in to change this behavior in the constructor of the command or the source generator attribute.

@michael-hawker michael-hawker added improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change open discussion ☎️ An issue open for active community discussion optimization ☄ Performance or memory usage improvements labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements ✨ Improvements to an existing functionality introduce breaking changes 💥 This change would be a breaking change open discussion ☎️ An issue open for active community discussion optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant