Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with mutiple UI Tests #4007

Merged
21 commits merged into from
Jun 23, 2021
Merged

Fix issues with mutiple UI Tests #4007

21 commits merged into from
Jun 23, 2021

Conversation

Rosuavio
Copy link
Contributor

@Rosuavio Rosuavio commented Apr 28, 2021

Fixes issues with having many UI tests.

After adding a basic test for the RangeSelector the UI test began to fail, sometimes other tests than the added one. There was some issues with managing resources both in the TAEF environment and in MSTest. Now those issues and inconsistencies should be ironed out.

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Apr 28, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Rosuavio
Copy link
Contributor Author

@azchohfi No clue whats going on. Everything works locally.

@ghost
Copy link

ghost commented May 27, 2021

This PR has been marked as "needs attention 👋" and awaiting a response from the team.

@Rosuavio Rosuavio changed the title Add RangeSelector UI Test Fix issues with mutiple UI Tests Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker michael-hawker added this to the 7.1 milestone Jun 8, 2021
@michael-hawker
Copy link
Member

@msftbot merge when @azchohfi approves

@ghost
Copy link

ghost commented Jun 8, 2021

Hello @michael-hawker!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @azchohfi

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@Rosuavio
Copy link
Contributor Author

It seems like there is an issue with closing the app
https://dev.azure.com/dotnet/WindowsCommunityToolkit/_build/results?buildId=53460&view=logs&j=4a47a688-b50e-58f6-4d2c-6d1b829fc8e2&t=79f5e95d-f2e4-5ca6-da45-561db0f3887c&l=122
A fall back method seems kill the test app anyways. I tried to figure this out but to no avail.
It seems that the value for testAppMainWindowTitle in the TestApplicationInfo ctor is used for finding a test window that has should have the __GoBackInvoker and the __CloseAppInvoker. Simply adding the __CloseAppInvoker did not work. We need to make it so this code can find the Window or the AppFrameWindow that has __CloseAppInvoker in it by setting its Name to the value we pass in for testAppMainWindowTitle.
https://github.com/microsoft/microsoft-ui-xaml/blob/9052972906c8a0a1b6cb5d5c61b27d6d27cd7f11/test/testinfra/MUXTestInfra/Infra/Application.cs#L73-L82

@ghost ghost merged commit fe30893 into CommunityToolkit:main Jun 23, 2021
@michael-hawker
Copy link
Member

Woot! 🎉🎉🎉 I'll re-base my PR when I get back to it with the last couple of changes that came in. Once I have a few GridSplitter tests, I'll probably split that PR into two anyway.

@Rosuavio Rosuavio deleted the rangeselector-uitests branch June 23, 2021 22:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants