Go the extra mile to Not depend on newtonsoft.json package?

[xied75]

Related to closed issue: #750

Currently there are 28 C# files that are referencing newtonsoft.json, most inside service part; I can't judge all of these, but at least it is possible to remove the dependency and simply use DataContractJsonSerializer in the case of ObjectStorage/BaseObjectStorageHelper.cs.

Being The de facto standard in C# world, newtonsoft.json is great; but here the toolkit is something fundamental too, if we go a bit further, the toolkit then can be lean and mean, saving final UWP appx being bloated.

(The netstandard1.0 newtonsoft.json 9.0.1 dll is 458KB in size!)

[hermitdave]

We will have a discussion regarding this for toolkit v1.4

[deltakosh]

As long as we can keep the services backward compatible, I'm fine removing json.net

[Odonno]

I am just wondering why the WIndows team did not integrated the Newtonsoft.Json library inside the Windows SDK, liek they did with SQLite.

Otherwise, if we can remove a dependency, I vote for it.

[hermitdave]

looking at https://github.com/Microsoft/UWPCommunityToolkit/tree/dev/Microsoft.Toolkit.Uwp/Helpers/ObjectStorage IMO it will be difficult to achieve same functionality with native libraries. I think we could ask James to create a #uwp wrapper for it ?

[windowstoolkitbot]

This issue seems inactive. It will automatically be closed in 14 days if there is no activity.

[michael-hawker]

@nmetulev I started using Newtonsoft.Json for the Monaco Editor wrapper as it was being used in the Toolkit already. I'll see how it works to switch.

[nmetulev]

There are already many controls and helpers that are already using Newtonsoft.Json extensively. Removing it from the toolkit would be a large undertaking and will not be possible at this time

[jimm98y]

Would it be possible to at least lower the version of the Newtonsoft dependency to 8.0.1? We are using Unity 2017 in the project because of the NET scripting backend and HoloLens support and currently all our Unity stuff breaks because this NuGet bumps the Newtonsoft.Json to 10.x and the UnityEngine does not support it apparently.

[azchohfi]

I'm going to reopen this, since it is something we are working on.

[michael-hawker]

@azchohfi I had #3060 to track that as this one was talking about DataContractSerializer vs. System.Text.Json. We probably only need one, which would you prefer we keep open?

We can assign the one that remains open to the 7.0 milestone as it looks like we can do this earlier than we originally thought.

[azchohfi]

Oh, my bad. Its that one, not this one.