Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify directory for dotnet to install to and execute from. #567

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Nov 22, 2024

This PR attempts to fix the ongoing CI errors caused by GitHub Actions updating the image to include net9.0 unexpectedly.

This setup forces only the specified dotnet version to be available when dotnet --list-sdks is run, avoiding the errors caused by the introduction of dotnet 9 and unblocking us while we work to resolve them in #563.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Nov 25, 2024

Looks like we're still getting NU1903 for Newtonsoft.Json in one of our test projects.

Checking locally, I've verified that these transitive references are only included on the test heads and don't affect our users. Since we're doing the fixup already in #563, we can suppress these for now to unblock the CI and undo when the update to net9 is complete.

@Arlodotexe Arlodotexe merged commit fa08f10 into main Nov 25, 2024
23 checks passed
@Arlodotexe Arlodotexe deleted the fix/ci/unexpected-net9 branch November 25, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants