Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing partial keyword to VectorChangedEventArgs class #444

Closed

Conversation

lhak
Copy link
Contributor

@lhak lhak commented Jun 28, 2024

Fixes

PR Type

What kind of change does this PR introduce?

Adds missing partial keyword to VectorChangedEventArgs, which is necessary to support AOT

What is the current behavior?

AdvancedCollectionView crashes when AOT is enabled

What is the new behavior?

Improves behavior when AOT is enabled

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

@Arlodotexe Arlodotexe self-assigned this Jul 9, 2024
@Arlodotexe Arlodotexe self-requested a review July 9, 2024 20:12
@Arlodotexe
Copy link
Member

Currently tracking AoT support in CommunityToolkit/Tooling-Windows-Submodule#195

@Arlodotexe
Copy link
Member

Closing in favor of #457

@Arlodotexe Arlodotexe closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants