Update to WinAppSdk 1.6, enable AoT on gallery head #195

Arlodotexe · 2024-06-20T05:56:27Z

This PR:

Updates our dependency on Microsoft.WindowsAppSdk to the latest 1.6
Enables AoT publishing for the WinAppSDK gallery head when building release
Updates msbuild props as needed for the above changes to build successfully

…to head, removed redundant RuntimeIdentifiers definition on libraries.

Arlodotexe · 2024-06-20T06:13:19Z

A local release/AoT build worked as expected the first time, but subsequent builds are giving this error message, even after a full and proper clean on the tooling repo:

17>0 IID calculations/fetches patched
13>0 IID calculations/fetches patched
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\CommunityToolkit.WinUI.Animations.AnimationDictionary.WinRTVtable.g.cs(21,13,21,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs(588,33,588,113): error CS0234: The type or namespace name 'List' does not exist in the namespace 'ABI.System.Collections.Generic' (are you missing an assembly reference?)
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs(1851,33,1851,61): error CS0234: The type or namespace name 'CommunityToolkit' does not exist in the namespace 'ABI' (are you missing an assembly reference?)
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(29,13,29,62): error CS0436: The type 'IReadOnlyList_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IReadOnlyList_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(35,13,35,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(125,13,125,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(179,29,179,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(198,29,198,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(217,29,217,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(242,13,242,62): error CS0436: The type 'IReadOnlyList_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IReadOnlyList_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(248,13,248,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(351,29,351,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(389,29,389,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(408,29,408,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(439,13,439,60): error CS0436: The type 'IEnumerator_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerator_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(483,29,483,76): error CS0436: The type 'IEnumerator_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerator_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(535,29,535,76): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(560,13,560,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(565,13,565,62): error CS0436: The type 'IReadOnlyList_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IReadOnlyList_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(671,13,671,60): error CS0436: The type 'IEnumerator_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerator_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(699,13,699,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(735,29,735,90): error CS0234: The type or namespace name 'List_Microsoft_UI_Xaml_UIElement' does not exist in the namespace 'WinRT.GenericHelpers' (are you missing an assembly reference?)
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(783,13,783,60): error CS0436: The type 'IEnumerable_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerable_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGlobalVtableLookup.g.cs(787,13,787,60): error CS0436: The type 'IEnumerator_object' in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs' conflicts with the imported type 'IEnumerator_object' in 'CommunityToolkit.WinUI.Extensions, Version=8.1.0.0, Culture=neutral, PublicKeyToken=null'. Using the type defined in 'C:\Users\arlog\source\repos\Windows\components\Animations\src\obj\Release\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenerator\WinRTGenericInstantiation.g.cs'.
19>Done building project "CommunityToolkit.WinUI.Animations.csproj" -- FAILED.

I wonder if this could be related to our troubles in CommunityToolkit/Windows#169, considering the latest insights from 8.1-rc 🤔

MultiTarget/PackageReferences/WinAppSdk.props

Resolves https://github.com/CommunityToolkit/Tooling-Windows-Submodule/pull/195/files#r1662838806

Arlodotexe · 2024-07-02T19:57:29Z

@michael-hawker Locally, I've removed all usages of InternalsVisibleTo and got a successful debug/release build with AoT turned off.

With AoT turned back on, we still get these errors:


       "C:\Users\arlog\source\uwp\lib\Windows\tooling\ProjectHeads\AllComponents\winappsdk\CommunityToolkit.App.WinAppSdk.csproj" (Clean;Build target) (1:7) ->        
       "C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj" (default target) (5:52) ->
       (CoreCompile target) ->
         C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\obj\x64\Debug\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenera 
       tor\WinRTGlobalVtableLookup.g.cs(324,29): error CS0234: The type or namespace name 'List_Microsoft_UI_Xaml_UIElement' does not exist in the namespace 'WinRT.Ge 
       nericHelpers' (are you missing an assembly reference?) [C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.cspro 
       j::TargetFramework=net8.0-windows10.0.22621.0]
         C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\obj\x64\Debug\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenera 
       tor\WinRTGenericInstantiation.g.cs(588,33): error CS0234: The type or namespace name 'List' does not exist in the namespace 'ABI.System.Collections.Generic' (a 
       re you missing an assembly reference?) [C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramewo 
       rk=net8.0-windows10.0.22621.0]
         C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\obj\x64\Debug\net8.0-windows10.0.22621.0\WinRT.SourceGenerator\Generator.WinRTAotSourceGenera 
       tor\WinRTGenericInstantiation.g.cs(1851,33): error CS0234: The type or namespace name 'CommunityToolkit' does not exist in the namespace 'ABI' (are you missing 
        an assembly reference?) [C:\Users\arlog\source\uwp\lib\Windows\components\Animations\src\CommunityToolkit.WinUI.Animations.csproj::TargetFramework=net8.0-wind 
       ows10.0.22621.0]

edit: work on InternalsVisibleTo pushed to CommunityToolkit/Windows#446 for review, no AoT enabled on this branch.

Sergio0694 · 2024-07-02T20:18:18Z

@Arlodotexe to double check, can you also try building against the latest CsWinRT build from the staging/AOT branch? You can just download the package from the artifacts (pick the latest commit from that branch) and setup a local feed for that.

Also cc. @manodasanW for those generator errors.

manodasanW · 2024-07-02T20:30:22Z

@Arlodotexe Can you set EmitCompilerGeneratedFiles in the csproj and share the generated files from the obj folder so I can see how the generated code corresponds with the errors.

Arlodotexe · 2024-07-02T21:42:18Z

@Arlodotexe Can you set EmitCompilerGeneratedFiles in the csproj and share the generated files from the obj folder so I can see how the generated code corresponds with the errors.

Here are the requested files: Animations.obj.Debug.zip

Arlodotexe · 2024-07-02T21:44:15Z

@Arlodotexe to double check, can you also try building against the latest CsWinRT build from the staging/AOT branch? You can just download the package from the artifacts (pick the latest commit from that branch) and setup a local feed for that.

Found the staging/AOT branch, but the DevOps feed is private.

manodasanW · 2024-07-02T21:57:47Z

Thanks @Arlodotexe All 3 errors look related to our KeyVauluePair bug (microsoft/CsWinRT#1638) which is fixed for our next preview release.

if (typeName == "System.Collections.Generic.KeyValuePair`2[Microsoft.UI.Xaml.UIElement,System.Collections.Generic.List`1[Microsoft.UI.Xaml.UIElement]]") { _ = global::WinRT.GenericHelpers.List_Microsoft_UI_Xaml_UIElement.Initialized;

Arlodotexe · 2024-07-02T23:11:11Z

Thanks @manodasanW, looks like that solved our issues on the library projects!

The last remaining issue is on the app head:

51>C:\Users\arlog\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1560,5): error APPX1101: Payload contains two or more files with the same destination path 'WinRT.Runtime.dll'. Source files: 
51>C:\Users\arlog\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1560,5): error APPX1101: C:\Users\arlog\.nuget\packages\microsoft.windows.sdk.net.ref\10.0.22621.35-preview\lib\net6.0\WinRT.Runtime.dll
51>C:\Users\arlog\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1560,5): error APPX1101: C:\Users\arlog\.nuget\packages\microsoft.windows.cswinrt\2.1.0-prerelease-ci.240702.1\lib\net6.0\WinRT.Runtime.dll
51>Done building project "CommunityToolkit.App.WinAppSdk.csproj" -- FAILED.
========== Build: 50 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Seems like a packaging error, WinRT.Runtime.dll is being included by both Microsoft.Windows.CSWinRT and Microsoft.Windows.Sdk.Net.Ref.

manodasanW · 2024-07-03T01:37:24Z

Thanks @manodasanW, looks like that solved our issues on the library projects!

The last remaining issue is on the app head:

51>C:\Users\arlog\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1560,5): error APPX1101: Payload contains two or more files with the same destination path 'WinRT.Runtime.dll'. Source files: 
51>C:\Users\arlog\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1560,5): error APPX1101: C:\Users\arlog\.nuget\packages\microsoft.windows.sdk.net.ref\10.0.22621.35-preview\lib\net6.0\WinRT.Runtime.dll
51>C:\Users\arlog\.nuget\packages\microsoft.windowsappsdk\1.6.240531000-experimental1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1560,5): error APPX1101: C:\Users\arlog\.nuget\packages\microsoft.windows.cswinrt\2.1.0-prerelease-ci.240702.1\lib\net6.0\WinRT.Runtime.dll
51>Done building project "CommunityToolkit.App.WinAppSdk.csproj" -- FAILED.
========== Build: 50 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Seems like a packaging error, WinRT.Runtime.dll is being included by both Microsoft.Windows.CSWinRT and Microsoft.Windows.Sdk.Net.Ref.

I know we had a problem here we fixed with authoring WinRT components in C# that had this issue, but I don't think you are doing that here. In this scenario, .NET should have determined the newer version and picked that. I assume that CsWinRT package is from our feed that we had built in the pipeline right? I will probably need a binlog to investigate what is happening. Might want to also try clearing your bin / obj to see if that helps.

Arlodotexe · 2024-07-04T00:07:00Z

I assume that CsWinRT package is from our feed that we had built in the pipeline right?

That's correct @manodasanW, this is using CsWinRT 2.1.0-prerelease-ci.240702.1. Here's a debug binlog, built just after cleaning bin/obj: CommunityToolkit.App.WinAppSdk.msbuild.zip

manodasanW · 2024-07-25T00:15:23Z

@Arlodotexe Can you try out the preview we released yesterday.

CsWinRT 2.1.0-prerelease.240722.1
Windows SDK projection: 10.0.<sdk_ver>.37-preview

https://github.com/microsoft/CsWinRT/releases/tag/2.1.0-prerelease.240722.1

michael-hawker · 2024-07-31T18:56:00Z

Kicking the failed job, probably CommunityToolkit/Windows#347 again?

Arlodotexe · 2024-07-31T21:49:42Z

Kicking the failed job, probably CommunityToolkit/Windows#347 again?

I'm working on fixing all the AoT annotations locally before I dig into that too much. Cause might be related.

ProjectHeads/App.Head.WinAppSdk.props

…comment)

…h experimental2

manodasanW · 2024-08-14T18:58:43Z

@Arlodotexe I saw you had updated WindowsSdkPackageVersion to 38, you want to keep it on 37-preview until we address the type conflict issue in WinAppSDK. See my previous comment here. It is fine to increment the WinAppSDK version to preview1.

MultiTarget/PackageReferences/WinAppSdk.props

…ppSDK 1.6 Preview1

Arlodotexe · 2024-08-16T18:49:35Z

I've got successful local builds with the latest changes, but CI in both CommunityToolkit/Windows#457 and CommunityToolkit/Labs-Windows#561 are throwing this:

55>C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: Payload contains two or more files with the same destination path 'WinRT.Runtime.dll'. Source files:  [C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]
2024-08-16T18:38:50.0377208Z ##[error]C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: C:\Users\runneradmin\.nuget\packages\microsoft.windows.sdk.net.ref\10.0.22621.37-preview\lib\net6.0\WinRT.Runtime.dll 
2024-08-16T18:38:50.0382780Z ##[error]C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: C:\Users\runneradmin\.nuget\packages\microsoft.windows.cswinrt\2.1.1\lib\net8.0\WinRT.Runtime.dll

We saw a similar error to this earlier, looks like our solution before was to update CsWinRT and the Windows SDK projection.

@manodasanW anything you could add to this?

Arlodotexe · 2024-08-16T21:36:35Z

I've got successful local builds with the latest changes, but CI in both CommunityToolkit/Windows#457 and CommunityToolkit/Labs-Windows#561 are throwing this:

55>C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: Payload contains two or more files with the same destination path 'WinRT.Runtime.dll'. Source files:  [C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]
2024-08-16T18:38:50.0377208Z ##[error]C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: C:\Users\runneradmin\.nuget\packages\microsoft.windows.sdk.net.ref\10.0.22621.37-preview\lib\net6.0\WinRT.Runtime.dll 
2024-08-16T18:38:50.0382780Z ##[error]C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: C:\Users\runneradmin\.nuget\packages\microsoft.windows.cswinrt\2.1.1\lib\net8.0\WinRT.Runtime.dll

We saw a similar error to this earlier, looks like our solution before was to update CsWinRT and the Windows SDK projection.

@manodasanW anything you could add to this?

Ah, I think I see why the build error is happening in the CI but not locally. The error is on the test head, not the gallery head. That's odd because we don't have AoT enabled on our test head, it's just the update to Wasdk 1.6 🤔

Arlodotexe · 2024-08-16T22:27:30Z

I've got successful local builds with the latest changes, but CI in both CommunityToolkit/Windows#457 and CommunityToolkit/Labs-Windows#561 are throwing this:
55>C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: Payload contains two or more files with the same destination path 'WinRT.Runtime.dll'. Source files:  [C:\a\Windows\Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]
2024-08-16T18:38:50.0377208Z ##[error]C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: C:\Users\runneradmin\.nuget\packages\microsoft.windows.sdk.net.ref\10.0.22621.37-preview\lib\net6.0\WinRT.Runtime.dll 
2024-08-16T18:38:50.0382780Z ##[error]C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.6.240807006-preview1\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1616,5): error APPX1101: C:\Users\runneradmin\.nuget\packages\microsoft.windows.cswinrt\2.1.1\lib\net8.0\WinRT.Runtime.dll 
We saw a similar error to this earlier, looks like our solution before was to update CsWinRT and the Windows SDK projection.
@manodasanW anything you could add to this?
Ah, I think I see why the build error is happening in the CI but not locally. The error is on the test head, not the gallery head. That's odd because we don't have AoT enabled on our test head, it's just the update to Wasdk 1.6 🤔

Turning off AoT on the gallery yields the same error:

MultiTarget/PackageReferences/WinAppSdk.props

Sergio0694

MultiTarget/EnabledTargetFrameworks.props

MultiTarget/PackageReferences/WinAppSdk.props

MultiTarget/WinUI.Extra.props

Arlodotexe added 2 commits June 20, 2024 00:50

Update to WinAppSdk 1.6.240531000-experimental1

9e54bb0

Enabled AoT for WinAppSdk 1.6-experimental1. Added RuntimeIdentifier …

9349c6c

…to head, removed redundant RuntimeIdentifiers definition on libraries.

Sergio0694 requested changes Jun 28, 2024

View reviewed changes

MultiTarget/PackageReferences/WinAppSdk.props Outdated Show resolved Hide resolved

Arlodotexe commented Jun 28, 2024

View reviewed changes

MultiTarget/PackageReferences/WinAppSdk.props Outdated Show resolved Hide resolved

Arlodotexe added 2 commits June 28, 2024 15:35

Update MultiTarget/PackageReferences/WinAppSdk.props

82f8495

Merge branch 'main' into wasdk/1.6

5e643c4

Sergio0694 requested changes Jul 2, 2024

View reviewed changes

MultiTarget/PackageReferences/WinAppSdk.props Outdated Show resolved Hide resolved

Arlodotexe commented Jul 2, 2024

View reviewed changes

MultiTarget/PackageReferences/WinAppSdk.props Outdated Show resolved Hide resolved

Update MultiTarget/PackageReferences/WinAppSdk.props

49cb231

Resolves https://github.com/CommunityToolkit/Tooling-Windows-Submodule/pull/195/files#r1662838806

This was referenced Jul 2, 2024

Removed usage of InternalsVisibleTo in all components CommunityToolkit/Windows#446

Open

Problems with InternalsVisibleTo CommunityToolkit/Windows#441

Open

Arlodotexe mentioned this pull request Jul 23, 2024

Add missing partial keyword to VectorChangedEventArgs class CommunityToolkit/Windows#444

Closed

11 tasks

Update to prerelease packages for Wasdk AoT

a9d1270

Arlodotexe mentioned this pull request Jul 31, 2024

Updated to WinAppSdk 1.6, fixed AoT annotations CommunityToolkit/Windows#457

Merged

Arlodotexe added 2 commits August 1, 2024 11:40

Disabled AoT on test head, enabled on gallery

371a247

Merge branch 'main' into wasdk/1.6

063405b

Sergio0694 requested changes Aug 1, 2024

View reviewed changes

ProjectHeads/App.Head.WinAppSdk.props Show resolved Hide resolved

Arlodotexe added 6 commits August 7, 2024 18:34

Update to Microsoft.WindowsAppSDK 1.6.240701003-experimental2

66595f7

Bump CsWinRT and WindowsSdkPackageVersion to latest stable version

15e3d12

Add WinAppSDK 1.6 workaround. See CommunityToolkit/Labs-Windows#561 (…

127bdc3

…comment)

Revert WindowsSdkPackageVersion to 10.0.22621.37-preview to align wit…

25c4ea8

…h experimental2

Update Microsoft.WindowsAppSDK to 1.6.240807006-preview1

edda2be

Update WindowsSdkPackageVersion for Wasdk 1.6 preview1

336ef4c

Update transient WebView2 reference to 1.0.2730-prerelease

236955c

Sergio0694 reviewed Aug 14, 2024

View reviewed changes

MultiTarget/PackageReferences/WinAppSdk.props Show resolved Hide resolved

Arlodotexe added 2 commits August 15, 2024 12:05

Revert WindowsSdkPackageVersion to 10.0.22621.37-preview for WindowsA…

2fcca69

…ppSDK 1.6 Preview1

Add partial to resolve CsWinRT1028

c3d33c3

Restore default enabled TFMs

287689f

Arlodotexe mentioned this pull request Aug 16, 2024

Update to Microsoft.WindowsAppSDK 1.6, enable AoT. #205

Open

michael-hawker mentioned this pull request Aug 16, 2024

app sdk 1.6 preview1 Breaking Ui ( CommunityToolkit.WinUI.Controls ) microsoft/WindowsAppSDK#4649

Closed

Arlodotexe added 2 commits August 16, 2024 17:59

Reverting 49cb231. See #195 (comment)

4dbd18a

Remove clean task to resolve CommunityToolkit/Windows#457 (comment)

456673a

Sergio0694 reviewed Aug 19, 2024

View reviewed changes

MultiTarget/PackageReferences/WinAppSdk.props Show resolved Hide resolved

Merge branch 'main' into wasdk/1.6

d19db7e

Sergio0694 approved these changes Aug 23, 2024

View reviewed changes

MultiTarget/EnabledTargetFrameworks.props Show resolved Hide resolved

MultiTarget/PackageReferences/WinAppSdk.props Show resolved Hide resolved

MultiTarget/WinUI.Extra.props Show resolved Hide resolved

MultiTarget/WinUI.Extra.props Show resolved Hide resolved

Arlodotexe merged commit df780af into main Aug 23, 2024
8 checks passed

Arlodotexe added a commit that referenced this pull request Aug 23, 2024

Reverting 49cb231. See #195 (comment)

4f3d83c

Arlodotexe deleted the wasdk/1.6 branch August 23, 2024 18:40

Arlodotexe mentioned this pull request Aug 26, 2024

Update Microsoft.WindowsAppSDK to 1.6-preview2 #208

Merged

Arlodotexe mentioned this pull request Sep 4, 2024

Update Microsoft.WindowsAppSDK to 1.6-preview2 CommunityToolkit/Windows#492

Merged

This was referenced Sep 16, 2024

Enabled CsWinRTAotWarningLevel 2 #212

Merged

Fix analyzer warnings for CsWinRTAotWarningLevel 2 CommunityToolkit/Windows#507

Merged

Fix analyzer warnings for CsWinRTAotWarningLevel 2 CommunityToolkit/Labs-Windows#572

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to WinAppSdk 1.6, enable AoT on gallery head #195

Update to WinAppSdk 1.6, enable AoT on gallery head #195

Arlodotexe commented Jun 20, 2024

Arlodotexe commented Jun 20, 2024 •

edited

Loading

Arlodotexe commented Jul 2, 2024 •

edited

Loading

Sergio0694 commented Jul 2, 2024

manodasanW commented Jul 2, 2024

Arlodotexe commented Jul 2, 2024

Arlodotexe commented Jul 2, 2024

manodasanW commented Jul 2, 2024

Arlodotexe commented Jul 2, 2024

manodasanW commented Jul 3, 2024

Arlodotexe commented Jul 4, 2024 •

edited

Loading

manodasanW commented Jul 25, 2024

michael-hawker commented Jul 31, 2024

Arlodotexe commented Jul 31, 2024 •

edited

Loading

manodasanW commented Aug 14, 2024

Arlodotexe commented Aug 16, 2024

Arlodotexe commented Aug 16, 2024

Arlodotexe commented Aug 16, 2024

Sergio0694 left a comment

Update to WinAppSdk 1.6, enable AoT on gallery head #195

Update to WinAppSdk 1.6, enable AoT on gallery head #195

Conversation

Arlodotexe commented Jun 20, 2024

Arlodotexe commented Jun 20, 2024 • edited Loading

Arlodotexe commented Jul 2, 2024 • edited Loading

Sergio0694 commented Jul 2, 2024

manodasanW commented Jul 2, 2024

Arlodotexe commented Jul 2, 2024

Arlodotexe commented Jul 2, 2024

manodasanW commented Jul 2, 2024

Arlodotexe commented Jul 2, 2024

manodasanW commented Jul 3, 2024

Arlodotexe commented Jul 4, 2024 • edited Loading

manodasanW commented Jul 25, 2024

michael-hawker commented Jul 31, 2024

Arlodotexe commented Jul 31, 2024 • edited Loading

manodasanW commented Aug 14, 2024

Arlodotexe commented Aug 16, 2024

Arlodotexe commented Aug 16, 2024

Arlodotexe commented Aug 16, 2024

Sergio0694 left a comment

Choose a reason for hiding this comment

Arlodotexe commented Jun 20, 2024 •

edited

Loading

Arlodotexe commented Jul 2, 2024 •

edited

Loading

Arlodotexe commented Jul 4, 2024 •

edited

Loading

Arlodotexe commented Jul 31, 2024 •

edited

Loading